Privacy_XH

Third Party Plugins to CMSimple - how to install, use and create plugins

Moderator: Tata

Post Reply
bca
Posts: 288
Joined: Tue Sep 15, 2009 4:49 pm

Privacy_XH

Post by bca » Fri Apr 27, 2018 2:59 pm

Just looking at Privacy_XH.
Is it necessary to have two actions on the agreement ie tick then continue?

Surely we only need one button saying "Agree" (or similar)

B

cmb
Posts: 12777
Joined: Tue Jun 21, 2011 11:04 am
Location: Mü-Sa, RLP, DE
Contact:

Re: Privacy_XH

Post by cmb » Fri Apr 27, 2018 9:56 pm

bca wrote:
Fri Apr 27, 2018 2:59 pm
Just looking at Privacy_XH.
Is it necessary to have two actions on the agreement ie tick then continue?

Surely we only need one button saying "Agree" (or similar)
I have to admit that this is rather cumbersome, but at least some jurisdictions may require the explicitness (the German jurisdiction is quite picky, for instance). And I had originally taken this design from https://ico.org.uk/ – where it has been changed later to an opt-in version, which is now JS only (so there's no chance to opt-out, if the JS doesn't work for whatever reason).

Anyhow, you can change it easily by replacing these lines with the following (untested, though):

Code: Select all

    <input type="hidden" name="privacy_agree">
    <button class="submit" name="privacy_submit"><?=$this->text('checkbox')?></button>
Christoph M. Becker –Plugins for CMSimple_XH, but not for CMSimple 4+

bca
Posts: 288
Joined: Tue Sep 15, 2009 4:49 pm

Re: Privacy_XH

Post by bca » Sat Apr 28, 2018 4:47 pm

Thanks Christoph.
That works fine and is much better :D

B

bca
Posts: 288
Joined: Tue Sep 15, 2009 4:49 pm

Re: Privacy_XH

Post by bca » Tue Jun 05, 2018 10:53 am

This line causes a HTML validation error.

Code: Select all

<form id="privacy" name="privacy" action="" method="post">
According to here action is not required on HTML5 if its not going anywhere

I've edited it in privacy.php and the error goes.

A bit pedantic I know :lol:


B

cmb
Posts: 12777
Joined: Tue Jun 21, 2011 11:04 am
Location: Mü-Sa, RLP, DE
Contact:

Re: Privacy_XH

Post by cmb » Wed Jun 06, 2018 2:44 pm

bca wrote:
Tue Jun 05, 2018 10:53 am
This line causes a HTML validation error.

Code: Select all

<form id="privacy" name="privacy" action="" method="post">
According to here action is not required on HTML5 if its not going anywhere
IIRC, the action attribute was required in HTML 4.01, so I put it in back then. Of course, it doesn't serve any useful purpose anymore. Thanks!
Christoph M. Becker –Plugins for CMSimple_XH, but not for CMSimple 4+

Post Reply