I have improved the internationalization of the search results, which was assumably clumsy for some languages (r615). The clumsy wording regarding some actions is only used on the settings page, which might be
completely removed.
On having had a closer look at the clumsy error notices, I'm not sure anymore, if we should try to improve this (for now at least). These error messages are typically constructed by e(), which receives a key for $tx['error'] and a key for $tx['filetype'] and simply concatenates the strings. At first I thought we could do something like:
Code: Select all
$tx['error']['notwritable']="The %s is not writeable";
But that doesn't work for arbitrary languages. In Germany it would have to be "Die %s ist nicht schreibbar", what would be okay for a file. But what about a folder: "Die Ordner ist nicht schreibbar". This could be catered for by avoiding the article: "%s is not writeable", but that already isn't as nice as it should be, and above all I expect problems for other languages. A solution would be to have separate language strings for all combinations, but as there are 10 filetypes we would end up with 90 new language strings. As these messages are solely used as error messages, they are normaly not shown in the front-end of the website. So we may consider to stick with the clumsy wording. The webmaster might be able to bear with them.
Other clumsy constructions seem to be relicts of the old internal filebrowser, which was removed from CMSimple_XH 1.5:
Code: Select all
$tx['error']['tolarge']="is too large! Maximum size is set to";
$tx['error']['wrongext']="Wrong file extension in";
$tx['files']['bytes']="bytes";
$tx['files']['totalsize']="Total size";
$tx['images']['usedin']="Used in";
$tx['result']['uploaded']="uploaded";
These are not used anymore by the core or the standard plugins, and I guess they are not used by other extensions, so we can simply remove them (except for $tx['images']['usedin'] which is used by the filebrowser, and should be moved to its own language files).
Other than that I found the following relicts of the old plugin selectbox resp. some former error handling in the pluginloader:
Code: Select all
$tx['menu']['available_plugins']="Plugins: ";
$tx['menu']['select_plugin']="Select plugin ...";
$tx['error']['plugin_error']="Plugin error: ";
I suggest to remove them.
What remains is the internationalization of the link checker ($tx['link'][] and $tx['validate'][]), which may be changed when the
link checker will be overhauled.