XH 1.6: $tx[meta][codepage]

[cmb]

Hello Community,

since CMSimple_XH 1.5 $tx[meta][codepage] has to be "UTF-8". Otherwise saving from the editor will fail, if non UTF-8 characters are contained in the page heading. In CMSimple_XH 1.5 a check is made, if $tx[meta][codepage] is UTF-8.

I suggest removing this option from the language files for XH 1.6. As it might be used by plugins, we can define it hard coded after inclusion of the language file in cms.php, and suppress it for Settings->Language.

Christoph

[Tata]

+1
Maybe there are more variables still remaining which could eventually be hardcoded?

[cmb]

Maybe there are more variables still remaining which could eventually be hardcoded?

While working on my branch for 1.6 (that will only be a suggestion for a cleaning step, before proceeding with new features), I've already removed $cf[plugins][folder] and $cf[functions][file] completely. $cf[scripting][regexp] should probably be hardcoded (might be used by plugins). I assume nobody has ever changed these config options--at least I don't see any reason to make this configurable.

[Holger]

I suggest removing this option from the language files for XH 1.6. As it might be used by plugins, we can define it hard coded after inclusion of the language file in cms.php, and suppress it for Settings->Language.

+1

I've already removed $cf[plugins][folder] and $cf[functions][file] completely

+1

$cf[scripting][regexp] should probably be hardcoded (might be used by plugins)

+1

Holger

[cmb]

Please note that the general issue of removing/hardcoding config options is related to svasti's suggestion to hide some options: http://cmsimpleforum.com/viewtopic.php? ... 009#p29897.

[Holger]

Hi Christoph,

While working on my branch for 1.6

Today I had a first look at your branch:
Whow! That cleanup looks very promising

KR
Holger