Hello Community,
since CMSimple_XH 1.5 $tx[meta][codepage] has to be "UTF-8". Otherwise saving from the editor will fail, if non UTF-8 characters are contained in the page heading. In CMSimple_XH 1.5 a check is made, if $tx[meta][codepage] is UTF-8.
I suggest removing this option from the language files for XH 1.6. As it might be used by plugins, we can define it hard coded after inclusion of the language file in cms.php, and suppress it for Settings->Language.
Christoph
XH 1.6: $tx[meta][codepage]
XH 1.6: $tx[meta][codepage]
Christoph M. Becker – Plugins for CMSimple_XH
Re: XH 1.6: $tx[meta][codepage]
+1
Maybe there are more variables still remaining which could eventually be hardcoded?
Maybe there are more variables still remaining which could eventually be hardcoded?
CMSimple.sk
It's no shame to ask for an answer if all efforts failed.
But it's awful to ask without any effort to find the answer yourself.
It's no shame to ask for an answer if all efforts failed.
But it's awful to ask without any effort to find the answer yourself.
Re: XH 1.6: $tx[meta][codepage]
While working on my branch for 1.6 (that will only be a suggestion for a cleaning step, before proceeding with new features), I've already removed $cf[plugins][folder] and $cf[functions][file] completely. $cf[scripting][regexp] should probably be hardcoded (might be used by plugins). I assume nobody has ever changed these config options--at least I don't see any reason to make this configurable.Tata wrote:Maybe there are more variables still remaining which could eventually be hardcoded?
Christoph M. Becker – Plugins for CMSimple_XH
Re: XH 1.6: $tx[meta][codepage]
+1cmb wrote:I suggest removing this option from the language files for XH 1.6. As it might be used by plugins, we can define it hard coded after inclusion of the language file in cms.php, and suppress it for Settings->Language.
+1cmb wrote:I've already removed $cf[plugins][folder] and $cf[functions][file] completely
+1cmb wrote:$cf[scripting][regexp] should probably be hardcoded (might be used by plugins)
Holger
Re: XH 1.6: $tx[meta][codepage]
Please note that the general issue of removing/hardcoding config options is related to svasti's suggestion to hide some options: http://cmsimpleforum.com/viewtopic.php? ... 009#p29897.
Christoph M. Becker – Plugins for CMSimple_XH
Re: XH 1.6: $tx[meta][codepage]
Hi Christoph,
Whow! That cleanup looks very promising
KR
Holger
Today I had a first look at your branch:cmb wrote:While working on my branch for 1.6
Whow! That cleanup looks very promising
KR
Holger