[new free onepage template] fhs-sectionsOP

Please post the URLs to pages, where you've made a CMSimple template available for download

Moderator: mikey

frase
Posts: 5085
Joined: Thu Apr 21, 2016 6:32 am
Location: Saxony
Contact:

Re: [new free onepage template] fhs-sectionsOP

Post by frase » Wed Oct 27, 2021 1:42 pm

cmb wrote:
Wed Oct 27, 2021 1:28 pm
That looks very relevant. Shouldn't that be a[href*="#Sections-1-3"]?
This comes from Holger's JS and is probably caused by this website. Although the calls in this Script are actually all correct (with quotes).
It does not exist in the original.

doczimut
Posts: 126
Joined: Thu Dec 25, 2008 1:10 pm
Location: Normandy (France)

Re: [new free onepage template] fhs-sectionsOP

Post by doczimut » Wed Oct 27, 2021 2:05 pm

file: /plugins/one-page/jquery.onepage.js
Ligne 62 to replace

Code: Select all

var $active = $nav.find("a[href*=#"
by

Code: Select all

$active = $nav.find("a[href*='#'"
I no longer have Chrome console error messages.
But is it good?

frase
Posts: 5085
Joined: Thu Apr 21, 2016 6:32 am
Location: Saxony
Contact:

Re: [new free onepage template] fhs-sectionsOP

Post by frase » Wed Oct 27, 2021 2:22 pm

doczimut wrote:
Wed Oct 27, 2021 2:05 pm
But is it good?
I don't think that this change is good. After all, the search is for a specific string (.find).
I don't really know.
But anyway. In Ludwig's templates the problem also occurs - and Holger's script is not used there.

doczimut
Posts: 126
Joined: Thu Dec 25, 2008 1:10 pm
Location: Normandy (France)

Re: [new free onepage template] fhs-sectionsOP

Post by doczimut » Wed Oct 27, 2021 2:38 pm

I'm not a specialist enough, but the script contains in the header:

Code: Select all

@copyright 2016 Holger Irmler <http://cmsimple.holgerirmler.de/>
And I no longer have in the Chrome console the messages:

Code: Select all

jquery.min.js:2 Uncaught Error: Syntax error, unrecognized expression: a[href*=...]

frase
Posts: 5085
Joined: Thu Apr 21, 2016 6:32 am
Location: Saxony
Contact:

Re: [new free onepage template] fhs-sectionsOP

Post by frase » Wed Oct 27, 2021 2:57 pm

doczimut wrote:
Wed Oct 27, 2021 2:38 pm
And I no longer have in the Chrome console the messages:
Then it's all right.
How does it look for you now?
(I've lost track.)
With Holger's script, does the up button work for you?
With the original script it does not work?
Or does it only depend on the https?

cmb
Posts: 14225
Joined: Tue Jun 21, 2011 11:04 am
Location: Bingen, RLP, DE
Contact:

Re: [new free onepage template] fhs-sectionsOP

Post by cmb » Wed Oct 27, 2021 3:10 pm

doczimut wrote:
Wed Oct 27, 2021 2:05 pm
file: /plugins/one-page/jquery.onepage.js
Ligne 62 to replace

Code: Select all

var $active = $nav.find("a[href*=#"
by

Code: Select all

$active = $nav.find("a[href*='#'"
I no longer have Chrome console error messages.
But is it good?
This doesn't look quite right. It seems that string is extended in the next line(s), so the second apostrophe would need to go at the end.
Christoph M. Becker – Plugins for CMSimple_XH

doczimut
Posts: 126
Joined: Thu Dec 25, 2008 1:10 pm
Location: Normandy (France)

Re: [new free onepage template] fhs-sectionsOP

Post by doczimut » Wed Oct 27, 2021 3:18 pm

To summarize: it works on my side, with my browsers, when accessing by https ("back to top" button visible) and invisible when accessing by http (pages of the templates offered in demo).
The errors reported by the Chrome console: jquery.min.js: 2 Uncaught Error: Syntax error, unrecognized expression: a [href*=...] no longer appear with: var $active = $nav.find("a[href*='#" + $(this) .attr('id') + "']"); instead of: var $active = $nav.find("a[href*=#" + $(this) .attr('id') + "]");
The display or not of the "back to top" button seems to be linked to an https access or not, and obviously this depends on the browsers installed, since for my part the button does not appear in http and obviously appears other internet users.
Last edited by doczimut on Wed Oct 27, 2021 3:57 pm, edited 3 times in total.

lck
Posts: 2963
Joined: Wed Mar 23, 2011 11:43 am
Contact:

Re: [new free onepage template] fhs-sectionsOP

Post by lck » Wed Oct 27, 2021 5:13 pm

Have you also activated "Migrate" and "Autoload" in the plugin configuration of jQuery? Well, "Autoload" is not absolutely necessary, as it is already loaded by the template, but it doesn't hurt.
http://holgerirmler.de/op_jquery/#Download wrote:Das angepasste Plugin gibt es vorerst hier in der jeweils aktuellen Version zum Download.
Bitte nicht vergessen: jQuery aktivieren und bei updates Browsercache leeren!
If this is activated, the error messages in the console should have disappeared and everything should work.
„Bevor du den Pfeil der Wahrheit abschießt, tauche die Spitze in Honig!“   👉 Ludwig's XH-Templates for MultiPage & OnePage

frase
Posts: 5085
Joined: Thu Apr 21, 2016 6:32 am
Location: Saxony
Contact:

Re: [new free onepage template] fhs-sectionsOP

Post by frase » Wed Oct 27, 2021 5:45 pm

When using Holger's script do not forget ->

Code: Select all

var onepage_customOffset = 150;
This belongs in the template.

lck
Posts: 2963
Joined: Wed Mar 23, 2011 11:43 am
Contact:

Re: [new free onepage template] fhs-sectionsOP

Post by lck » Wed Oct 27, 2021 5:46 pm

@Frank
Verständnisfrage, template.htm:

Code: Select all

</body>
</html>
<?php
if(function_exists('hi_cnc')) {
    hi_cnc();
}
?>
Ist das so in Ordnung, dass der Funktionsaufruf außerhalb von html steht?
„Bevor du den Pfeil der Wahrheit abschießt, tauche die Spitze in Honig!“   👉 Ludwig's XH-Templates for MultiPage & OnePage

Post Reply