Moderator: Tata
Hi Christophcmb wrote:Pretty cool! Do you plan to use the "new Upload API" mentionend in the blog post? Might be rather reasonable for large images.
Code: Select all
save_onsavecallback: function()Very nice! Some suggestions:manu wrote:ImageUpload is executed after save button pressed, say the modified images are uploaded onto the image directory.
The problem is, first I have to run imageUpload and wait until its done. Unfortunately I only get a callback on success (at the moment, I'm waiting for improvements), not on fail. That why I hesitate to gray out things...cmb wrote:What I would like is better feedback for the user. When the internet connection is slow, after pressing the save button there doesn't seem to happen anything if modified images have to be uploaded. At least some indication that there's something happening would be good; if only making the <body> partially transparent.
If the image upload fails, it would be nice if the user could see the error message right away (instead of having to look into the log file). Otherwise they might think that everything worked fine, switch to view mode, and all the modifications are gone without further notice. At least marking the editor as not dirty should better not be done, if the upload failed.
Compression before upload would be perfect. At the moment all is new. I just wait and see what happens on the developers side @moxiecode.What I also would like is that the images are (optionally?) stored as JPEG to save bandwidth later. Ideally the images would be transferred in the final storage format, but I understand that this would require to implement JPEG compression in the browser. It might still be useful to recompress the images after upload.
As I understand it, it would be possible to use a custom images_upload_handler. This might also be used to check whether trying to upload makes sense (by comparing the image size with CMSimple_XH's Images → Maxsize setting).manu wrote:The problem is, first I have to run imageUpload and wait until its done. Unfortunately I only get a callback on success (at the moment, I'm waiting for improvements), not on fail. That why I hesitate to gray out things...
ACK. However, the image upload might be done synchronously; surely not the best option, but not too bad either, because the required session would prohibit parallel processing anyway (the default session handler locks the session files exclusively). And most certainly it would be possible to use asynchronous XHR and syncing that otherwise.manu wrote:But still, tinymce has to wait until the upload handler has processed all images and triggers the callback.
Code: Select all
$temp = str_replace(
'%LANGUAGE%', $tiny_language !='en' ?
// 'language_url: "' .
// CMSIMPLE_ROOT.'plugins/tinymce4/tinymce/langs/' .
// $tiny_language.'.js",' :
'language: "' . $tiny_language .'",' :
'language: "en",', $temp
);Code: Select all
tinymce /
|- langs/
|- themes/
|- plugins/
|- utils/ <-- From compat3x
|- langstiny_mce_popup.js <-- From compat3x
tinymce/
plugins/compat3x
|- css/
|- img/
|- plugin.js
|- plugin.min.jsCode: Select all
$temp = str_replace(
'%LANGUAGE%', $tiny_language !='en' ?
TINYMCE4_VARIANT == 'CDN' ?
'language_url: "' .
CMSIMPLE_ROOT.'plugins/tinymce4/tinymce/langs/' .
$tiny_language.'.js",'
: 'language: "' . $tiny_language .'",'
: 'language: "en",', $temp
);
index.php Line:84WARNING: file(http://tinymce.cachefly.net/index.txt) [function.file]: failed to open stream: Operation timed out
/*****/plugins/tinymce4/index.php:84
Code: Select all
function tinymce4GetCdnVersions()
{
return file("http://tinymce.cachefly.net/index.txt");
}Code: Select all
function tinymce4GetCdnVersion()
{
return " ";