Bug in Menumanager plugin

[Holger]

In my content.htm is a upper- and lowercase mix of <hx>-tags so the page will not validate XHTML.
I've found that these mixed <Hx></hx> tags caused by a bug in the Menumanager plugin.
It happens when you drag'n drop a page to another menulevel.
For now only tested with Menumanager 2007 - (Club-)Version and latest Firefox 2 on WAMPP.

Can someone confirm that or, much better , can someone fix that?

Holger

[Till]

can someone fix that?

In admin.php search for:

Code: Select all

$leveledPage = preg_replace('/<H[1-3]/i','<H'.$pageInfo[1] , $c[$pageInfo[0]],1);
$leveledPage = preg_replace('/H[1-3]>/i','H'.$pageInfo[1].'>' , $leveledPage,1);

Change the capital H to small h letters. Then it is fixed.

But I found another cute bug. After moving a menulevel3 item to menulevel2 I received this HTML code:

Code: Select all

<h2>An H3 heading</h3>

I bet this wont validate either

Till

[Holger]

In admin.php search for:

Code: Select all

$leveledPage = preg_replace('/<H[1-3]/i','<H'.$pageInfo[1] , $c[$pageInfo[0]],1);
$leveledPage = preg_replace('/H[1-3]>/i','H'.$pageInfo[1].'>' , $leveledPage,1);

Change the capital H to small h letters. Then it is fixed.

Amazing, I've looked into all files except admin.php .

Thanks for your help!

Holger

Edit:
Now I've tested with version 2007a, that's the lates version without integrated renaming of headings.
It seems that there's no issue like described above.

[Till]

But I found another cute bug. After moving a menulevel3 item to menulevel2 I received this HTML code:

Code: Select all

<h2>An H3 heading</h3>

I bet this wont validate either

Yes, this bug appears in menumanager 2007b. But to fix it you change:

Code: Select all

$leveledPage = preg_replace('/h[1-3]>/i','h'.$pageInfo[1].'>' , $leveledPage,1);

to

Code: Select all

$leveledPage = preg_replace('/h[1-3]>/i','h'.$pageInfo[1].'>' , $leveledPage);

You just remove the number "1" at the end of the line.

Till

[soong]

I was unsure if the first bug also affects versions lower than 2007b. So I checked the admin.php of Menumanager 2006c - there are no capital 'H'-tags in it. Just for others to know

2006c is the last free version of Menu Manager, right?

[CMSimple-Styles.com]

The new version (2008a) is now online for free! I hope i have fixed all known bugs, but if new ones are found i will quickly create a version 2008b to deal with them. Please test this version and report any bugs you can find, It now also supports up to 6 menulevels when set in CMSimple.