Memberpages_XH minor enhancements

Third Party Plugins to CMSimple - how to install, use and create plugins

Moderator: Tata

Post Reply
deeseecee
Posts: 53
Joined: Tue Jan 22, 2013 1:22 pm
Location: Bochum, Germany

Memberpages_XH minor enhancements

Post by deeseecee » Wed Jun 28, 2017 9:34 am

During the process of updating the memberpages-plugin I noticed a bug in the memberpages plugin: a space is missing in the 'logged in as' statement

In index.php, line 459

Code: Select all

        : $loggedinnotice
should be changed to

Code: Select all

        : $loggedinnotice . ' '
Furthemore, I suggest an enhancement to make the 'login', 'logout' and 'change data'-buttons styleable:

In index.php, lines 427, 434 and 444, the statement

Code: Select all

<button type="submit">
should be extended to

Code: Select all

<button type="submit" class="membp_member_button">
This way all the buttons can be styled the same way.

It would be nice to have these changes merged into the Github memberpages repository.

cmb
Posts: 14225
Joined: Tue Jun 21, 2011 11:04 am
Location: Bingen, RLP, DE
Contact:

Re: Memberpages_XH minor enhancements

Post by cmb » Wed Jun 28, 2017 12:45 pm

deeseecee wrote:During the process of updating the memberpages-plugin I noticed a bug in the memberpages plugin: a space is missing in the 'logged in as' statement
Noted.
deeseecee wrote:Furthemore, I suggest an enhancement to make the 'login', 'logout' and 'change data'-buttons styleable:
Also noted.

However, for me, Memberpages is extremly low priority; I'd rather invest time into Register_XH.
Christoph M. Becker – Plugins for CMSimple_XH

aceaccis
Posts: 71
Joined: Tue May 30, 2017 7:09 am

Re: Memberpages_XH minor enhancements

Post by aceaccis » Mon Jul 10, 2017 10:45 am

Hi,

during the extremly low priority on Memberpages I changed to Register_XH.

There is just one functionality that I miss on Register -->
only_members.PNG
Is there an way to do that manualy by scripting ?

Thx and greetings

Chris
You do not have the required permissions to view the files attached to this post.
Chris S. aus B
Hoster: df.eu
Domains: 25 an der Zahl
CMS: CMSimple_XH, jeweils 1.6.10 und nun 1.7.0

cmb
Posts: 14225
Joined: Tue Jun 21, 2011 11:04 am
Location: Bingen, RLP, DE
Contact:

Re: Memberpages_XH minor enhancements

Post by cmb » Mon Jul 10, 2017 11:31 am

aceaccis wrote:There is just one functionality that I miss on Register -->
Do you mean managing the access protection via a page data tab? That is not yet implemented. For now this has to be done with CMSimple scripting.
Christoph M. Becker – Plugins for CMSimple_XH

aceaccis
Posts: 71
Joined: Tue May 30, 2017 7:09 am

Re: Memberpages_XH minor enhancements

Post by aceaccis » Mon Jul 10, 2017 1:41 pm

Hi Christoph,

now I mean the funktionality that only registered Users are able to see an Link in the Menue.

Under Memberpages there was the possibility to activate some link can be shown only by registered (loged in) members.

I can live without the members Tab in the admin menue.

At the moment only Pages (section) can be protected by adding the Function code

Code: Select all

{{{access('admin,member,vip')}}}
but the Link is shown in the menue there is no function to say this link is only visible at VIP status like this ?

Greetings Chris
Chris S. aus B
Hoster: df.eu
Domains: 25 an der Zahl
CMS: CMSimple_XH, jeweils 1.6.10 und nun 1.7.0

cmb
Posts: 14225
Joined: Tue Jun 21, 2011 11:04 am
Location: Bingen, RLP, DE
Contact:

Re: Memberpages_XH minor enhancements

Post by cmb » Mon Jul 10, 2017 5:23 pm

aceaccis wrote:Under Memberpages there was the possibility to activate some link can be shown only by registered (loged in) members.
That shouldn't even be optional in Register_XH. IMO it makes no sense to show a page in the menu that can't be accessed. The following would work as expected:

Code: Select all

{{{PLUGIN:access('admin,member,vip');}}}
I have forgotten to adjust the regexp to the newer short forms of the plugin call.

To make Register_XH 1.5 work (only) with the documented plugin call syntax replace this line with:

Code: Select all

    if (preg_match('/{{{access\((.*?)\)}}}/isu', $c[$i], $matches)) {
(look ma, a readable regexp! :))
Christoph M. Becker – Plugins for CMSimple_XH

aceaccis
Posts: 71
Joined: Tue May 30, 2017 7:09 am

Re: Memberpages_XH minor enhancements

Post by aceaccis » Tue Jul 11, 2017 9:08 am

Hi Christoph ,

I did the change but nothing changed :? .

I'm not shure if you know what I mean with visible links :)

Ok an unregistered User calls http:// my.website.de

He will see on the Left the Menue strukture of the Page like :
  • - Startseite
    - Wir über Uns
    |- das Team
    - Leistungen
under Memberspage wenn you enable link unvisible for unregistered User the Links to the protected Site was hided.

Registered User means the user will log in with his credentials would see following menue on the same page :
  • - Startseite
    - Wir über Uns
    |- das Team
    - Leistungen
    - Kunden <-- only visible when the user is logged in.
Why ? Because it makes no sense to have there 4-5 or more Links the User is klicking on it und get the Massage " Oh sorry Bro you are not allowed to get in " :-)

Best regards

Chris.

P.S. : Christoph is nothing what would be so important is just a question if there is any possibility to do that very simple in an shorten way.
I know that you are very busy at the moment.
Chris S. aus B
Hoster: df.eu
Domains: 25 an der Zahl
CMS: CMSimple_XH, jeweils 1.6.10 und nun 1.7.0

cmb
Posts: 14225
Joined: Tue Jun 21, 2011 11:04 am
Location: Bingen, RLP, DE
Contact:

Re: Memberpages_XH minor enhancements

Post by cmb » Tue Jul 11, 2017 11:15 am

aceaccis wrote:Why ? Because it makes no sense to have there 4-5 or more Links the User is klicking on it und get the Massage " Oh sorry Bro you are not allowed to get in " :-)
Exactly! :)

Another try: replace this line with:

Code: Select all

    if (preg_match('/access\((.*?)\)/isu', $c[$i], $matches)) { 
Christoph M. Becker – Plugins for CMSimple_XH

aceaccis
Posts: 71
Joined: Tue May 30, 2017 7:09 am

Re: Memberpages_XH minor enhancements

Post by aceaccis » Tue Jul 11, 2017 11:27 am

LOVE YOU !!!

Great that is what i like :-)

Greetings Chris
Chris S. aus B
Hoster: df.eu
Domains: 25 an der Zahl
CMS: CMSimple_XH, jeweils 1.6.10 und nun 1.7.0

Post Reply