xhtml_endtags in function languagemenu()

A place to report and discuss bugs - please mention CMSimple-version, server, platform and browser version
Post Reply
Holger
Site Admin
Posts: 3243
Joined: Mon May 19, 2008 7:10 pm
Location: Hessen, Germany
Contact:

xhtml_endtags in function languagemenu()

Post by Holger » Thu Jul 10, 2008 2:17 pm

Hi

With CMSimple version 3.2 the function languagemenu() does not return
closed img-tags for the flag images with xhtml_endtags = true.

Better use tag(img...) in cms.php line 639.

Holger

Holger
Site Admin
Posts: 3243
Joined: Mon May 19, 2008 7:10 pm
Location: Hessen, Germany
Contact:

Re: xhtml_endtags in function languagemenu()

Post by Holger » Tue Aug 05, 2008 10:14 am

Ups,

Peter posted that already at cmsimple.com:
Harteg wrote: A user wrote me:
Hello Peter,
don't know why I have to purchase a license of cmsimple to post on the cmsimple-forum, but maybe I can tell you about two small things I found in the code of the cms.php!

To generate good and valide XHTML-Code I think the languagemenue-function should not output
<img src="'.$pth['folder']['flags'] etc..
instead I used
.tag('img

this is found in ROW 635 and 640

and to get a valid print-link I think it would be a solution to write
else if(sv('QUERY_STRING') != '')$t = str_replace('&','&',sv('QUERY_STRING')).$t;

in the printlink-function near ROW 527 and then the &s in the Query_Strings are escaped!

Cheers and thanx for your work!

Post Reply