XH 1.6(.1): Incorrect redirections in FileEdit.php

A place to report and discuss bugs - please mention CMSimple-version, server, platform and browser version
Post Reply
cmb
Posts: 14225
Joined: Tue Jun 21, 2011 11:04 am
Location: Bingen, RLP, DE
Contact:

XH 1.6(.1): Incorrect redirections in FileEdit.php

Post by cmb » Thu Feb 27, 2014 1:46 pm

Hello Community,

I've found that the redirections after saving text and config files use relative URLs, but according to RFC 2616 section 14.30 it has to be an absolute URI. The solution is simple: just prepend CMSIMPLE_URL. Probably the cleanest solution would be to prepend it when $this->redir is assigned; another option would be to prepend it when the Location header field is set.

Christoph
Christoph M. Becker – Plugins for CMSimple_XH

cmb
Posts: 14225
Joined: Tue Jun 21, 2011 11:04 am
Location: Bingen, RLP, DE
Contact:

Re: XH 1.6(.1): Incorrect redirections in FileEdit.php

Post by cmb » Sun May 11, 2014 10:47 pm

cmb wrote:Probably the cleanest solution would be to prepend it when $this->redir is assigned; another option would be to prepend it when the Location header field is set.
Not sure what'd be cleaner; as the latter solution has to be fixed in two places only, I've chosen that (r1279).
Christoph M. Becker – Plugins for CMSimple_XH

Post Reply