A place to report and discuss bugs - please mention CMSimple-version, server, platform and browser version
-
svasti
- Posts: 1659
- Joined: Wed Dec 17, 2008 5:08 pm
Post
by svasti » Mon Feb 17, 2014 7:42 pm
just noticed in the generated source code:
Code: Select all
<li><a href="./cs/"><img src="./userfiles/images/flags//cs.gif" alt="cs" title=" cs " class="flag"></a> <a href="./de/"><img src="./userfiles/images/flags//de.gif" alt="de" title=" de " class="flag"></a> <a href="./fr/"><img src="./userfiles/images/flags//fr.gif" alt="fr" title=" fr " class="flag"></a> <a href="./nl/"><img src="./userfiles/images/flags//nl.gif" alt="nl" title=" nl " class="flag"></a> </li>
why double slashes?
why not in tplfuncs.php line 683
Code: Select all
$img = $pth['folder']['flags'] . $lang . '.gif';
instead of
Code: Select all
$img = $pth['folder']['flags'] . '/' . $lang . '.gif';
Or is it done on purpose?
svasti
-
cmb
- Posts: 14225
- Joined: Tue Jun 21, 2011 11:04 am
- Location: Bingen, RLP, DE
-
Contact:
Post
by cmb » Mon Feb 17, 2014 7:54 pm
Good catch! That seems to be a bug -- harmless, but nonetheless a bug.
-
cmb
- Posts: 14225
- Joined: Tue Jun 21, 2011 11:04 am
- Location: Bingen, RLP, DE
-
Contact:
Post
by cmb » Tue Feb 18, 2014 12:06 pm
I've fixed that now in the trunk (r1209) and the 1.6 branch (r1210). It occurs to me that we should have better and more unit tests, what currently would require a possibility to dynamically override functions; I'm not sure, however, if
runkit is a reasonable option.
BTW: we should consider using PNG images for the flag icons.