double slashes in language links

[svasti]

just noticed in the generated source code:

Code: Select all

<li><a href="./cs/"><img src="./userfiles/images/flags//cs.gif" alt="cs" title="&nbsp;cs&nbsp;" class="flag"></a> <a href="./de/"><img src="./userfiles/images/flags//de.gif" alt="de" title="&nbsp;de&nbsp;" class="flag"></a> <a href="./fr/"><img src="./userfiles/images/flags//fr.gif" alt="fr" title="&nbsp;fr&nbsp;" class="flag"></a> <a href="./nl/"><img src="./userfiles/images/flags//nl.gif" alt="nl" title="&nbsp;nl&nbsp;" class="flag"></a> </li>

why double slashes?

why not in tplfuncs.php line 683

Code: Select all

$img = $pth['folder']['flags'] . $lang . '.gif';

instead of

Code: Select all

$img = $pth['folder']['flags'] . '/' . $lang . '.gif';

Or is it done on purpose?

svasti

[cmb]

Good catch! That seems to be a bug -- harmless, but nonetheless a bug.

[cmb]

I've fixed that now in the trunk (r1209) and the 1.6 branch (r1210). It occurs to me that we should have better and more unit tests, what currently would require a possibility to dynamically override functions; I'm not sure, however, if runkit is a reasonable option.

BTW: we should consider using PNG images for the flag icons.