Filebrowser bug in CMSimple XH 1.6.8

A place to report and discuss bugs - please mention CMSimple-version, server, platform and browser version
Post Reply
tanavots
Posts: 69
Joined: Sat Feb 25, 2012 4:18 pm

Filebrowser bug in CMSimple XH 1.6.8

Post by tanavots » Tue Dec 13, 2016 6:44 pm

I'm expecting issue where tinimce(4) editor does not show file listing if I try to add image or link (add image button --> Browse). There is just empty page with error message

Code: Select all

%SCRIPT% %MESSAGE%
and buttons Create subfolder and Upload file. Tested on different sites in different servers and all have the same issue. If I replace plugin with old version from XH 1.6.7, file listing is working again.

Edit: I see that there is info about this in German forum. I try to translate... fixed and working!

cmb
Posts: 12770
Joined: Tue Jun 21, 2011 11:04 am
Location: Mü-Sa, RLP, DE
Contact:

Re: Filebrowser bug in CMSimple XH 1.6.8

Post by cmb » Tue Dec 13, 2016 9:56 pm

tanavots wrote:Edit: I see that there is info about this in German forum. I try to translate... fixed and working!
Great!

I'm repeating the quick-fix for others. Replace this line:

Code: Select all

                <legend><?php echo $this->translate('upload_file_to', XH_hsc($this->currentDirectory)); ?></legend>
by:

Code: Select all

                <legend><?php echo $this->translate('upload_file_to', $this->escapeForEventHandlerAttribute($this->currentDirectory)); ?></legend>
And this line:

Code: Select all

                <legend><?php echo $this->translate('create_subfolder_in', XH_hsc($this->currentDirectory)); ?></legend>
by:

Code: Select all

                <legend><?php echo $this->translate('create_subfolder_in', $this->escapeForEventHandlerAttribute($this->currentDirectory)); ?></legend>
Christoph M. Becker –Plugins for CMSimple_XH, but not for CMSimple 4+

cmb
Posts: 12770
Joined: Tue Jun 21, 2011 11:04 am
Location: Mü-Sa, RLP, DE
Contact:

Re: Filebrowser bug in CMSimple XH 1.6.8

Post by cmb » Wed Dec 14, 2016 4:23 pm

Fixed with r1692.
Christoph M. Becker –Plugins for CMSimple_XH, but not for CMSimple 4+

Post Reply