Page 1 of 1

Filebrowser bug in CMSimple XH 1.6.8

Posted: Tue Dec 13, 2016 6:44 pm
by tanavots
I'm expecting issue where tinimce(4) editor does not show file listing if I try to add image or link (add image button --> Browse). There is just empty page with error message

Code: Select all

%SCRIPT% %MESSAGE%
and buttons Create subfolder and Upload file. Tested on different sites in different servers and all have the same issue. If I replace plugin with old version from XH 1.6.7, file listing is working again.

Edit: I see that there is info about this in German forum. I try to translate... fixed and working!

Re: Filebrowser bug in CMSimple XH 1.6.8

Posted: Tue Dec 13, 2016 9:56 pm
by cmb
tanavots wrote:Edit: I see that there is info about this in German forum. I try to translate... fixed and working!
Great!

I'm repeating the quick-fix for others. Replace this line:

Code: Select all

                <legend><?php echo $this->translate('upload_file_to', XH_hsc($this->currentDirectory)); ?></legend>
by:

Code: Select all

                <legend><?php echo $this->translate('upload_file_to', $this->escapeForEventHandlerAttribute($this->currentDirectory)); ?></legend>
And this line:

Code: Select all

                <legend><?php echo $this->translate('create_subfolder_in', XH_hsc($this->currentDirectory)); ?></legend>
by:

Code: Select all

                <legend><?php echo $this->translate('create_subfolder_in', $this->escapeForEventHandlerAttribute($this->currentDirectory)); ?></legend>

Re: Filebrowser bug in CMSimple XH 1.6.8

Posted: Wed Dec 14, 2016 4:23 pm
by cmb
Fixed with r1692.