Conflicting Users and permissions with file uploads

A place to report and discuss bugs - please mention CMSimple-version, server, platform and browser version

Re: Conflicting Users and permissions with file uploads

Postby cmb » Tue Mar 13, 2012 8:37 pm

Hi Frank,

svasti wrote:I had to write a small php-program

Hmm, well, so we probably shouldn't add the chmod(), as writing small PHP programs is always a good exercise! :lol:

Thanks for the confirmation! I'll put it on the roadmap.

Christoph
Christoph M. Becker---Plugins for CMSimple_XH
cmb
 
Posts: 5481
Joined: Tue Jun 21, 2011 11:04 am
Location: Germany

Re: Conflicting Users and permissions with file uploads

Postby cmb » Tue Jul 17, 2012 1:24 pm

I've just added this to the TRUNK (r211). But I've noticed, that a notice is thrown after deleting a file, which is related to the fact, that the filename is given as "file" parameter in the POST request. But file is one of the "reserved" GP parameters (cmsimple/cms.php line 179), and so $f will be set to 'file' (cmsimple/adm.php line 70). That's probably harmless, but it might be cleaner to change the parameter to "filename" or so.
Christoph M. Becker---Plugins for CMSimple_XH
cmb
 
Posts: 5481
Joined: Tue Jun 21, 2011 11:04 am
Location: Germany

Re: Conflicting Users and permissions with file uploads

Postby svasti » Tue Jul 17, 2012 4:10 pm

cmb wrote:but it might be cleaner to change the parameter to "filename" or so.
+1
Little question, what do you mean by "GP" in GP parameters? Great Primadonna? Grand Program? Generated Prrrr?
svasti
 
Posts: 687
Joined: Wed Dec 17, 2008 5:08 pm
Location: Bielefeld, Germany

Re: Conflicting Users and permissions with file uploads

Postby cmb » Tue Jul 17, 2012 4:22 pm

svasti wrote:Little question, what do you mean by "GP" in GP parameters?

GET/POST, as this is what initvar() actually does: checking for $_GET and $_POST (in contrast $_REQUEST also holds the cookies, and the three parameter types are sometimes abbreviated as GPC).
Christoph M. Becker---Plugins for CMSimple_XH
cmb
 
Posts: 5481
Joined: Tue Jun 21, 2011 11:04 am
Location: Germany

Re: Conflicting Users and permissions with file uploads

Postby svasti » Tue Jul 17, 2012 5:47 pm

aahh, thx.
svasti
 
Posts: 687
Joined: Wed Dec 17, 2008 5:08 pm
Location: Bielefeld, Germany

Re: Conflicting Users and permissions with file uploads

Postby cmb » Thu Mar 28, 2013 9:22 pm

Hi svasti,

while trying to add the chmod() for XH 1.4.5, I've noticed that it's already there since XH 1.2. The filemanager of FCKEditor does a chmod() also (permissions are configurable, defaulting to 0777).

svasti wrote:I've had this problem on one server where I couldn't download image files uploaded by the customer and couldn't even change the permissions with filezilla, because the ftp wasn't the owner of the files.

Under which version of CMSimple was that?

Christoph
Christoph M. Becker---Plugins for CMSimple_XH
cmb
 
Posts: 5481
Joined: Tue Jun 21, 2011 11:04 am
Location: Germany

Previous

Return to Bugs

Who is online

Users browsing this forum: No registered users and 0 guests

cron