Filebrowser: filter files by extension

[cmb]

Hello Community,

in a German thread about KCFinder there was a discussion that might better be lead in this forum. It is about the file types (specified by the file extension) which are visible in the file browser. Currently that solely depends how the filebrowser is initially accessed:

• Adminmenu -> Files: userfiles
• Adminmenu -> Files -> Images resp. Editor -> Insert Image: images
• Adminmenu -> Files -> Downloads resp. Editor -> Insert Link: downloads
• Adminmenu -> Files -> Media resp. Editor -> Insert Media: media

This was absolutely reasonable in CMSimple_XH 1.5 where it was not possible to enter the other folders, but since XH 1.6 it is possible to call Adminmenu -> Files -> Images, for instance, and surf to the media folder; however, only the allowed image extensions will be visible in there. This might be a good feature or not. Consider you want to insert an image and an according image link for a lightbox (e.g. hi_fancybox). Inserting the image via the insert image dialog works as expected, but inserting the image link via the insert link dialog doesn't, because its browse button opens the filebrowser in "download" mode. That might not be regarded a problem, as one could add the required image file extensions to the allowed extensions for downloads.

However, we may consider to improve the situation. It should be possible to change the behavior completely, so that the allowed extensions don't depend on how the filebrowser was opened, but solely on the current folder. Another possibility would be to only make some exceptions, e.g. only when the filebrowser is opened in "download" mode (e.g. for inserting a link), the current folder is used to determine the allowed extensions; in other modes we could stick with the current solution.

Any suggestions?

Christoph

[cmb]

However, we may consider to improve the situation. It should be possible to change the behavior completely, so that the allowed extensions don't depend on how the filebrowser was opened, but solely on the current folder.

I have implemented this (r1271). While doing so, I noticed that it is not possible to switch to the userfiles/ folder, when the filebrowser has been opened for images, downloads or media. I have not changed this behavior, as it may be sensible.

However, I noticed a problem: what to do, if the user configured the four folders to be (partially) the same? In this case the type of the current folder can not be determined unambiguously. A solution would be to catch this case, and fall back to the old behavior. Not sure, if that's the best option though.

Any thoughts?

[cmb]

I have moved a more sophisticated suggestion to its own thread.

[cmb]

However, I noticed a problem: what to do, if the user configured the four folders to be (partially) the same? In this case the type of the current folder can not be determined unambiguously. A solution would be to catch this case, and fall back to the old behavior. Not sure, if that's the best option though.

We have to solve this issue some way or the other before we can release XH 1.6.2. Besides this issue the release could probably happen in the next few days (most items on the roadmap are already done).

[cmb]

However, I noticed a problem: what to do, if the user configured the four folders to be (partially) the same? In this case the type of the current folder can not be determined unambiguously. A solution would be to catch this case, and fall back to the old behavior.

I have implemented this (r1303).