Backup on logout of secondary languages

[svasti]

Hi developers,

I noticed when editing text first in language A and then in language B and logging out from language B that only the language B will get a backup.

What about implementing some counter ($de_edited=false; $en_edited=false; etc.) that would be set to true when any language got editied, and that on logout the counter would trigger the backup of the edited language contents.

Would have the additional benefit, that no superfluous backup would be triggered when I log in, do something in some plugin and log out without changing the content.htm.

Plugins like "logout_nobackup" wouldn't be needed any more.

[cmb]

What about implementing some counter ($de_edited=false; $en_edited=false; etc.) that would be set to true when any language got editied, and that on logout the counter would trigger the backup of the edited language contents.

The counter(s) would have to be permanent, however, e.g. stored in a session variable or a file.

Another possibility would be to compare the current content file with the latest backup on logout; if they have the same contents, no backup is necessary. To keep the additional memory consumption low, we might use md5_file() to compare hashes of the files -- collisions are very rare, and even if they happen the "error" would just be a duplicate backup.

Anyway, making backups of all (modified) language contents on logout would be great.

PS: I've put it on the roadmap.

[svasti]

If you don't mind I'd specify the roadmap item to: On logout: check which language content was changed and backup only that.

I like to keep real backups instead of producing duplicates, expecially if checking a website of a friend or a customer. Would be nice to be able to get rid of the plugin "Logout_nobackup".

[cmb]

If you don't mind I'd specify the roadmap item to: On logout: check which language content was changed and backup only that.

We might divide it into two roadmap items.

I like to keep real backups instead of producing duplicates, expecially if checking a website of a friend or a customer. Would be nice to be able to get rid of the plugin "Logout_nobackup".

Logging out without making a backup might still be useful in some cases. OTOH this could easily be accomplished by an alternative admin menu extension or even by the user manually requesting ?logout=no_backup.

[Holger]

Another possibility would be to compare the current content file with the latest backup on logout; if they have the same contents, no backup is necessary. To keep the additional memory consumption low, we might use md5_file() to compare hashes of the files -- collisions are very rare, and even if they happen the "error" would just be a duplicate backup.

Anyway, making backups of all (modified) language contents on logout would be great.

Good idea!
+1

[cmb]

Done (r1259-1261).