Explicit checking whether reading succeeded

Discussions and requests related to new CMSimple features, plugins, templates etc. and how to develop.
Please don't ask for support at this forums!
Post Reply
cmb
Posts: 14225
Joined: Tue Jun 21, 2011 11:04 am
Location: Bingen, RLP, DE
Contact:

Explicit checking whether reading succeeded

Post by cmb » Tue Jul 30, 2013 11:59 am

Hello Community,

in a German thread Michael reported strange Problems regarding lost content resp. pagedata. It seems that in this case content.htm resp. pagedata.php were not loaded for the save request.

I had a look at the respective code, and indeed there's no check, whether reading of content.htm and pagedata.php did actually succeed. I suggest we add that for CMSimple_XH 1.5.8 and 1.1.7, and stop script execution if the files couldn't be loaded, showing an appropriate error message (needs slight modifications to rfc() and PL_Page_Data_Model::PL_Page_Data_Model()).

Furthermore I suggest to add a note, if pagedata.php was newly created, what should only happen under normal circumstances, if the file is missing (i.e. after upgrading from classic CMSimple), what needs a slight modification of plugins/pluginloader/pagedata/index.php.

Christoph
Christoph M. Becker – Plugins for CMSimple_XH

Post Reply