Pluginloader tries to access above the root directory

[cmb]

Hello Developers,

I've just noticed, that the pluginloader tries to access a folder above CMSimple's root directory. It's in plugins/index.php line 124:

Code: Select all

if(file_exists('../plugins/pluginloader/languages/'.$sl.'.php')) 

This throws a open_basedir restriction warning, if CMSimple is installed in the web root and open_basedir is set to this folder.

If I'm not mistaken the following 2 lines are an equivalent replacement for line 119-139:

Code: Select all

$pluginloader_cfg['language'] = file_exists($pth['folder']['plugins'].'pluginloader/languages/'.$sl.'.php') ? $sl : 'en';
$pluginloader_cfg['folder_down'] = $pth['folder']['base'] == './' ? '' : '.';
 

Christoph

[svasti]

Hi Christoph,
reminds me of the quite old thread http://www.cmsimpleforum.com/viewtopic.php?f=7&t=783

Good idea to improve and shorten the code... why not put it on the roadmap?? Or better directly into the code of the next release?
svasti