IMO it's more than okay! I appreciate that you have encapsulated the retrieval of the options in a function; this way some global variables can be avoided.manu wrote:If this fix is ok I could do it for the filemanager accordingly.
About the selectbox: I'm not sure how to handle this. The most typical case are hardcoded options in the meta config (not yet implemented; a first draft can be found in http://www.cmsimpleforum.com/viewtopic. ... =10#p31549). For the core (languages and templates) I have hardcoded it to XH_CoreArrayFileEdit. Perhaps we should generalize this, and make it possible to specify a function (given by name, which will return an array of options) instead of a hardcoded list only. Simplest solution: if the select list contains only 1 element, this is treated as such a function.